Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14064018: Check that result of bmm.loadSubtree is still the selected item before applying disabled state to c… (Closed)

Created:
7 years, 8 months ago by aboxhall
Modified:
7 years, 8 months ago
CC:
chromium-reviews, arv+watch_chromium.org, yosin_UTC9
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Check that result of bmm.loadSubtree is still the selected item before applying disabled state to commands. BUG=230280 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
arv (Not doing code reviews)
LGTM
7 years, 8 months ago (2013-04-19 22:39:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/14064018/1
7 years, 8 months ago (2013-04-19 22:43:42 UTC) #2
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 02:06:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/14064018/1
7 years, 8 months ago (2013-04-21 00:02:30 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-21 00:08:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/14064018/1
7 years, 8 months ago (2013-04-21 00:59:07 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-21 01:06:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/14064018/1
7 years, 8 months ago (2013-04-22 01:57:35 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-22 03:43:08 UTC) #9
Message was sent while issue was closed. 
Change committed as 195434

Powered by Google App Engine
This is Rietveld 408576698