Use --internal-diff on svn 1.7+ to slightly reduce disk thrashing.

Use --internal-diff on svn 1.7+ to slightly reduce disk thrashing.

This just saves the need to create and remove an empty directory on every call to GenerateDiff.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=195328

[Peter Kasting, 2013-04-19 22:34:47]

https://codereview.chromium.org/14247007/ , stage 3.

[M-A Ruel, 2013-04-19 23:11:14]

lgtm

[commit-bot: I haz the power, 2013-04-19 23:13:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkasting@chromium.org/14064017/1

[commit-bot: I haz the power, 2013-04-19 23:15:56]

Change committed as 195328

[wtc, 2013-04-20 01:16:41]

https://chromiumcodereview.appspot.com/14064017/diff/1/scm.py
File scm.py (right):

https://chromiumcodereview.appspot.com/14064017/diff/1/scm.py#newcode800
scm.py:800: ["diff", "--config_dir", bogus_dir])

This change breaks the gcl command:

  $ gcl change deps_nss_new_directory_structure
  deps_nss_new_directory_structure changelist saved.
  Got an exception
  Command svn diff --config_dir /tmp/tmprDrpmZ DEPS returned non-zero exit
status 1 in /home/wtc/chrome8/src
  svn: invalid option: --config_dir
  Type 'svn help' for usage.

There is a typo: "--config_dir" should be "--config-dir".

[Peter Kasting, 2013-04-20 01:23:19]

On 2013/04/20 01:16:41, wtc wrote:
> There is a typo: "--config_dir" should be "--config-dir".

Will fix now.