Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8480)

Unified Diff: chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc

Issue 14063018: Implemented argument wrapping for CallJS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Get rid of macro. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc
index 1d016ec999cffa3bc3087fc54b80dcb9dd928eca..5a086ab36b35c0f1efecd5c6a2591e0b557d2c0d 100644
--- a/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc
@@ -88,28 +88,22 @@ void ErrorScreenHandler::HideCaptivePortal() {
void ErrorScreenHandler::SetUIState(ErrorScreen::UIState ui_state) {
ui_state_ = ui_state;
- base::FundamentalValue ui_state_value(static_cast<int>(ui_state));
- CallJS("login.ErrorMessageScreen.setUIState", ui_state_value);
+ CallJS("login.ErrorMessageScreen.setUIState", static_cast<int>(ui_state_));
}
void ErrorScreenHandler::SetErrorState(ErrorScreen::ErrorState error_state,
const std::string& network) {
error_state_ = error_state;
- base::FundamentalValue error_state_value(static_cast<int>(error_state));
- base::StringValue network_value(network);
CallJS("login.ErrorMessageScreen.setErrorState",
- error_state_value,
- network_value);
+ static_cast<int>(error_state_), network);
}
void ErrorScreenHandler::AllowGuestSignin(bool allowed) {
- base::FundamentalValue allowed_value(allowed);
- CallJS("login.ErrorMessageScreen.allowGuestSignin", allowed_value);
+ CallJS("login.ErrorMessageScreen.allowGuestSignin", allowed);
}
void ErrorScreenHandler::AllowOfflineLogin(bool allowed) {
- base::FundamentalValue allowed_value(allowed);
- CallJS("login.ErrorMessageScreen.allowOfflineLogin", allowed_value);
+ CallJS("login.ErrorMessageScreen.allowOfflineLogin", allowed);
}
void ErrorScreenHandler::NetworkErrorShown() {

Powered by Google App Engine
This is Rietveld 408576698