Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc

Issue 14063018: Implemented argument wrapping for CallJS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
index ba35ea39d2212e69de63d3fed33042f5de2f4ab4..b52b37496cf846c254415367db0267c0d7669e3a 100644
--- a/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc
@@ -78,28 +78,24 @@ void UpdateScreenHandler::PrepareToShow() {
}
void UpdateScreenHandler::ShowManualRebootInfo() {
- StringValue message(l10n_util::GetStringUTF16(IDS_UPDATE_COMPLETED));
- CallJS("cr.ui.Oobe.setUpdateMessage", message);
+ CallJS("cr.ui.Oobe.setUpdateMessage",
+ l10n_util::GetStringUTF16(IDS_UPDATE_COMPLETED));
}
void UpdateScreenHandler::SetProgress(int progress) {
- base::FundamentalValue progress_value(progress);
- CallJS("cr.ui.Oobe.setUpdateProgress", progress_value);
+ CallJS("cr.ui.Oobe.setUpdateProgress", progress);
}
void UpdateScreenHandler::ShowEstimatedTimeLeft(bool visible) {
- base::FundamentalValue visible_value(visible);
- CallJS("cr.ui.Oobe.showEstimatedTimeLeft", visible_value);
+ CallJS("cr.ui.Oobe.showEstimatedTimeLeft", visible);
}
void UpdateScreenHandler::SetEstimatedTimeLeft(const base::TimeDelta& time) {
- base::FundamentalValue seconds_value(time.InSecondsF());
- CallJS("cr.ui.Oobe.setEstimatedTimeLeft", seconds_value);
+ CallJS("cr.ui.Oobe.setEstimatedTimeLeft", time.InSecondsF());
}
void UpdateScreenHandler::ShowProgressMessage(bool visible) {
- base::FundamentalValue visible_value(visible);
- CallJS("cr.ui.Oobe.showProgressMessage", visible_value);
+ CallJS("cr.ui.Oobe.showProgressMessage", visible);
}
void UpdateScreenHandler::SetProgressMessage(ProgressMessage message) {
@@ -130,8 +126,7 @@ void UpdateScreenHandler::SetProgressMessage(ProgressMessage message) {
}
void UpdateScreenHandler::ShowCurtain(bool visible) {
- base::FundamentalValue visible_value(visible);
- CallJS("cr.ui.Oobe.showUpdateCurtain", visible_value);
+ CallJS("cr.ui.Oobe.showUpdateCurtain", visible);
}
void UpdateScreenHandler::RegisterMessages() {

Powered by Google App Engine
This is Rietveld 408576698