Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4641)

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc

Issue 14063018: Implemented argument wrapping for CallJS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
index edb0952750b7450d44fea8f78ac28eb54a0e43de..099c3302c119bd184e7640a40bc2d276a7ff904d 100644
--- a/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
@@ -67,7 +67,7 @@ void NetworkScreenHandler::Hide() {
}
void NetworkScreenHandler::ShowError(const string16& message) {
- CallJS("oobe.NetworkScreen.showError", base::StringValue(message));
+ CallJS("oobe.NetworkScreen.showError", message);
}
void NetworkScreenHandler::ClearErrors() {
@@ -89,10 +89,8 @@ void NetworkScreenHandler::ShowConnectingStatus(
void NetworkScreenHandler::EnableContinue(bool enabled) {
is_continue_enabled_ = enabled;
- if (!page_is_ready())
- return;
-
- CallJS("cr.ui.Oobe.enableContinueButton", base::FundamentalValue(enabled));
+ if (page_is_ready())
+ CallJS("cr.ui.Oobe.enableContinueButton", enabled);
}
// NetworkScreenHandler, BaseScreenHandler implementation: --------------------

Powered by Google App Engine
This is Rietveld 408576698