Disentangle field from transition stores.

Disentangle field from transition stores.

Committed: https://code.google.com/p/v8/source/detail?r=14223

[Toon Verwaest, 2013-04-10 15:17:44]

PTAL

[ulan, 2013-04-11 09:34:04]

LGTM

https://chromiumcodereview.appspot.com/14063006/diff/1/src/stub-cache.h
File src/stub-cache.h (right):

https://chromiumcodereview.appspot.com/14063006/diff/1/src/stub-cache.h#newco...
src/stub-cache.h:166: Handle<Code> ComputeStoreTransition(Handle<Name> name,
Nit: space between function declarations here and below.

https://chromiumcodereview.appspot.com/14063006/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

https://chromiumcodereview.appspot.com/14063006/diff/1/src/x64/stub-cache-x64...
src/x64/stub-cache-x64.cc:825: transition->LastAdded());
Nit: space between these lines.

https://chromiumcodereview.appspot.com/14063006/diff/1/src/x64/stub-cache-x64...
src/x64/stub-cache-x64.cc:887: int index =
lookup->GetFieldIndex().field_index();
Nit: space between these lines.

[Toon Verwaest, 2013-04-11 09:47:33]

Addressed comments

https://chromiumcodereview.appspot.com/14063006/diff/1/src/stub-cache.h
File src/stub-cache.h (right):

https://chromiumcodereview.appspot.com/14063006/diff/1/src/stub-cache.h#newco...
src/stub-cache.h:166: Handle<Code> ComputeStoreTransition(Handle<Name> name,
On 2013/04/11 09:34:04, ulan wrote:
> Nit: space between function declarations here and below.

Done.

https://chromiumcodereview.appspot.com/14063006/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):

https://chromiumcodereview.appspot.com/14063006/diff/1/src/x64/stub-cache-x64...
src/x64/stub-cache-x64.cc:825: transition->LastAdded());
On 2013/04/11 09:34:04, ulan wrote:
> Nit: space between these lines.

Done.

https://chromiumcodereview.appspot.com/14063006/diff/1/src/x64/stub-cache-x64...
src/x64/stub-cache-x64.cc:887: int index =
lookup->GetFieldIndex().field_index();
On 2013/04/11 09:34:04, ulan wrote:
> Nit: space between these lines.

Done.

[Toon Verwaest, 2013-04-11 09:48:14]

Committed patchset #2 manually as r14223 (presubmit successful).