Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 14061008: Have Rietveld.get_description() consistently strip CR and whitespace. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 7 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Have Rietveld.get_description() consistently strip CR and whitespace. This makes the commit description cleaner. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=199275

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M rietveld.py View 1 chunk +8 lines, -3 lines 4 comments Download
M tests/rietveld_test.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
7 years, 8 months ago (2013-04-26 18:15:54 UTC) #1
iannucci
https://codereview.chromium.org/14061008/diff/1/rietveld.py File rietveld.py (right): https://codereview.chromium.org/14061008/diff/1/rietveld.py#newcode89 rietveld.py:89: return '\n'.join(self.get('/%d/description' % issue).strip().splitlines()) So if it ended with ...
7 years, 8 months ago (2013-04-26 18:21:46 UTC) #2
M-A Ruel
https://codereview.chromium.org/14061008/diff/1/rietveld.py File rietveld.py (right): https://codereview.chromium.org/14061008/diff/1/rietveld.py#newcode89 rietveld.py:89: return '\n'.join(self.get('/%d/description' % issue).strip().splitlines()) On 2013/04/26 18:21:46, iannucci wrote: ...
7 years, 8 months ago (2013-04-26 18:23:53 UTC) #3
iannucci
lgtm
7 years, 7 months ago (2013-05-09 21:27:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/14061008/1
7 years, 7 months ago (2013-05-09 21:28:42 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 21:30:47 UTC) #6
Message was sent while issue was closed.
Change committed as 199275

Powered by Google App Engine
This is Rietveld 408576698