Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1406003005: Rename chrome/browser/android/datausage to data_usage (Closed)

Created:
5 years, 1 month ago by megjablon
Modified:
5 years, 1 month ago
CC:
chromium-reviews, sclittle, Raj, tbansal1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename chrome/browser/android/datausage to data_usage BUG=550657 Committed: https://crrev.com/174bc344a869b991db7c778f7380b08eca129dd2 Cr-Commit-Position: refs/heads/master@{#357946}

Patch Set 1 : #

Patch Set 2 : test fix #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1174 lines) Patch
M chrome/browser/android/chrome_jni_registrar.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/android/data_usage/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/android/data_usage/external_data_use_observer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/data_usage/external_data_use_observer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/android/data_usage/external_data_use_observer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/android/datausage/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/android/datausage/external_data_use_observer.h View 1 1 chunk +0 lines, -331 lines 0 comments Download
D chrome/browser/android/datausage/external_data_use_observer.cc View 1 1 chunk +0 lines, -343 lines 0 comments Download
D chrome/browser/android/datausage/external_data_use_observer_unittest.cc View 1 1 chunk +0 lines, -489 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
megjablon
5 years, 1 month ago (2015-11-04 22:47:28 UTC) #3
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-04 22:49:43 UTC) #4
tbansal (incorrect)
thanks for doing this. I believe a 1-line change is needed in chrome/chrome_tests_unit.gypi to update ...
5 years, 1 month ago (2015-11-04 22:57:14 UTC) #6
megjablon
On 2015/11/04 22:57:14, tbansal (incorrect) wrote: > thanks for doing this. I believe a 1-line ...
5 years, 1 month ago (2015-11-04 23:11:02 UTC) #7
Raj
https://chromiumcodereview.appspot.com/1406003005/diff/40001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://chromiumcodereview.appspot.com/1406003005/diff/40001/chrome/chrome_tests_unit.gypi#newcode16 chrome/chrome_tests_unit.gypi:16: 'browser/android//external_data_use_observer_unittest.cc', typo 'browser/android/data_usage/external_data_use_observer_unittest.cc',
5 years, 1 month ago (2015-11-04 23:16:52 UTC) #9
megjablon
https://chromiumcodereview.appspot.com/1406003005/diff/40001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://chromiumcodereview.appspot.com/1406003005/diff/40001/chrome/chrome_tests_unit.gypi#newcode16 chrome/chrome_tests_unit.gypi:16: 'browser/android//external_data_use_observer_unittest.cc', On 2015/11/04 23:16:52, Raj wrote: > typo > ...
5 years, 1 month ago (2015-11-04 23:24:17 UTC) #10
tbansal (incorrect)
lgtm
5 years, 1 month ago (2015-11-04 23:33:11 UTC) #11
sclittle
LGTM
5 years, 1 month ago (2015-11-04 23:38:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406003005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406003005/60001
5 years, 1 month ago (2015-11-05 00:22:58 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 1 month ago (2015-11-05 00:30:14 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 00:31:45 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/174bc344a869b991db7c778f7380b08eca129dd2
Cr-Commit-Position: refs/heads/master@{#357946}

Powered by Google App Engine
This is Rietveld 408576698