Issue 14057015: [Android] Fix null-build broken by https://codereview.chromium.org/14322004/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14057015: [Android] Fix null-build broken by https://codereview.chromium.org/14322004/ (Closed)

Created:
7 years, 8 months ago by Yaron

Modified:
7 years, 8 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org, shashi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Fix null-build broken by https://codereview.chromium.org/14322004/ The change unintentionally made the "always re-run strip" logic apply to non-component build as well. Restored the original logic. BUG=158821 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194991

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	build/android/strip_native_libraries.gypi	View		2 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/14057015/1

7 years, 8 months ago (2013-04-18 20:20:25 UTC) #3

Message was sent while issue was closed.

Change committed as 194991

Expand Messages | Collapse Messages