Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: build/common.gypi

Issue 14055005: Switch Isolate to noop on Mac (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix comment spacing Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index d39128b1e23488a54a4aa840dd5caf5af1b20df6..3d384df3608f7041d741858f422ad26c82733237 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -631,10 +631,12 @@
# overriden with GYP_DEFINES.
# TODO(maruel): Remove the conditions as more configurations are
# supported.
+ # TODO(csharp): Remove OS!="mac" once xcode can run the isolate code
+ # again.
# NOTE: The check for disable_nacl==0 and component=="static_library"
# can't be used here because these variables are not defined yet, but it
# is still not supported.
- ['inside_chromium_build==1 and OS!="ios" and OS!="android" and chromeos==0', {
+ ['inside_chromium_build==1 and OS!="mac" and OS!="ios" and OS!="android" and chromeos==0', {
'test_isolation_mode%': 'check',
}, {
'test_isolation_mode%': 'noop',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698