Issue 14055005: Switch Isolate to noop on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14055005: Switch Isolate to noop on Mac (Closed)

Created:
7 years, 8 months ago by csharp

Modified:
7 years, 8 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Switch Isolate to noop on Mac isolate is currently broken when run through xcode. R=maruel@chromium.org NOTRY=True BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193449

Patch Set 2 : Fix comment spacing #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/common.gypi	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm https://codereview.chromium.org/14055005/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/14055005/diff/1/build/common.gypi#newcode634 build/common.gypi:634: # TODO(csharp): Remove OS!="mac" once xcode can run ...

7 years, 8 months ago (2013-04-10 20:43:18 UTC) #2

csharp

https://codereview.chromium.org/14055005/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/14055005/diff/1/build/common.gypi#newcode634 build/common.gypi:634: # TODO(csharp): Remove OS!="mac" once xcode can run the ...

7 years, 8 months ago (2013-04-10 20:44:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/14055005/4001

7 years, 8 months ago (2013-04-10 20:44:41 UTC) #4

Message was sent while issue was closed.

Change committed as 193449

Expand Messages | Collapse Messages

Issue 14055005: Switch Isolate to noop on Mac (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix comment spacing #

Messages