Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14051004: Minor clean up in WorkerDevToolsManager (Closed)

Created:
7 years, 8 months ago by Vladislav Kaznacheev
Modified:
7 years, 8 months ago
Reviewers:
yurys
CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, darin-cc_chromium.org, pfeldman
Visibility:
Public.

Description

Minor clean up in WorkerDevToolsManager BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194902

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M content/browser/devtools/worker_devtools_manager.cc View 5 chunks +14 lines, -10 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
Vladislav Kaznacheev
7 years, 8 months ago (2013-04-11 09:21:31 UTC) #1
yurys
https://codereview.chromium.org/14051004/diff/1/content/browser/devtools/worker_devtools_manager.cc File content/browser/devtools/worker_devtools_manager.cc (left): https://codereview.chromium.org/14051004/diff/1/content/browser/devtools/worker_devtools_manager.cc#oldcode101 content/browser/devtools/worker_devtools_manager.cc:101: g_agent_map.Get().erase(worker_id_); Why did this move? https://codereview.chromium.org/14051004/diff/1/content/browser/devtools/worker_devtools_manager.cc#oldcode187 content/browser/devtools/worker_devtools_manager.cc:187: static void ...
7 years, 8 months ago (2013-04-15 05:24:18 UTC) #2
Vladislav Kaznacheev
https://codereview.chromium.org/14051004/diff/1/content/browser/devtools/worker_devtools_manager.cc File content/browser/devtools/worker_devtools_manager.cc (left): https://codereview.chromium.org/14051004/diff/1/content/browser/devtools/worker_devtools_manager.cc#oldcode101 content/browser/devtools/worker_devtools_manager.cc:101: g_agent_map.Get().erase(worker_id_); Because I needed to call a method from ...
7 years, 8 months ago (2013-04-15 13:10:27 UTC) #3
yurys
lgtm
7 years, 8 months ago (2013-04-15 13:34:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/14051004/1
7 years, 8 months ago (2013-04-18 09:13:02 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 12:50:30 UTC) #6
Message was sent while issue was closed. 
Change committed as 194902

Powered by Google App Engine
This is Rietveld 408576698