Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 14048018: Add create WGC3DInProcessCommandBuffer for on-screen context (Closed)

Created:
7 years, 8 months ago by boliu
Modified:
7 years, 8 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, apatrick_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add create WGC3DInProcessCommandBuffer for on-screen context The on-screen path will be by Android WebView for hardware draws. BUG=166777 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195162

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove out-of-date comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -29 lines) Patch
M cc/test/layer_tree_pixel_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/pixel_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/gpu/context_provider_in_process.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 3 chunks +18 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 8 chunks +52 lines, -19 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
boliu
I tried to follow the same API as the command buffer version. PTAL.
7 years, 8 months ago (2013-04-18 05:35:13 UTC) #1
boliu
Ping!
7 years, 8 months ago (2013-04-18 20:54:47 UTC) #2
piman
LGTM FWIW, but I'm not owner.
7 years, 8 months ago (2013-04-18 21:49:56 UTC) #3
jamesr
lgtm https://codereview.chromium.org/14048018/diff/1/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc File webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc (right): https://codereview.chromium.org/14048018/diff/1/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc#newcode93 webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc:93: // offscreen context. If parent is not NULL, ...
7 years, 8 months ago (2013-04-19 00:52:27 UTC) #4
boliu
https://codereview.chromium.org/14048018/diff/1/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc File webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc (right): https://codereview.chromium.org/14048018/diff/1/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc#newcode93 webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc:93: // offscreen context. If parent is not NULL, that ...
7 years, 8 months ago (2013-04-19 00:57:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/14048018/8001
7 years, 8 months ago (2013-04-19 00:58:06 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 13:29:08 UTC) #7
Message was sent while issue was closed.
Change committed as 195162

Powered by Google App Engine
This is Rietveld 408576698