Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4401)

Unified Diff: chrome/browser/chrome_browser_field_trials.cc

Issue 14048014: Fix SimpleCache field trial creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: about:flags Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/disk_cache/cache_creator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_field_trials.cc
diff --git a/chrome/browser/chrome_browser_field_trials.cc b/chrome/browser/chrome_browser_field_trials.cc
index 6f9c582a7e5d9b7f537f090dd26c6e950ad99522..dd1235ac4005f115e8b20adc401d7f913292d6ea 100644
--- a/chrome/browser/chrome_browser_field_trials.cc
+++ b/chrome/browser/chrome_browser_field_trials.cc
@@ -203,17 +203,18 @@ void ChromeBrowserFieldTrials::SetUpSimpleCacheFieldTrial() {
if (parsed_command_line_.HasSwitch(switches::kUseSimpleCacheBackend)) {
const std::string opt_value = parsed_command_line_.GetSwitchValueASCII(
switches::kUseSimpleCacheBackend);
- if (LowerCaseEqualsASCII(opt_value, "off")) {
- // This is the default.
- return;
- }
const base::FieldTrial::Probability kDivisor = 100;
scoped_refptr<base::FieldTrial> trial(
base::FieldTrialList::FactoryGetFieldTrial("SimpleCacheTrial", kDivisor,
- "No", 2013, 12, 31, NULL));
+ "ExperimentNo", 2013, 12, 31,
+ NULL));
trial->UseOneTimeRandomization();
+ if (LowerCaseEqualsASCII(opt_value, "off")) {
+ trial->AppendGroup("ExplicitNo", kDivisor);
+ return;
+ }
if (LowerCaseEqualsASCII(opt_value, "on")) {
- trial->AppendGroup("Yes", 100);
+ trial->AppendGroup("ExplicitYes", kDivisor);
return;
}
#if defined(OS_ANDROID)
@@ -221,8 +222,8 @@ void ChromeBrowserFieldTrials::SetUpSimpleCacheFieldTrial() {
// TODO(pasko): Make this the default on Android when the simple cache
// adds a few more necessary features. Also adjust the probability.
const base::FieldTrial::Probability kSimpleCacheProbability = 1;
- trial->AppendGroup("Yes", kSimpleCacheProbability);
- trial->AppendGroup("Control", kSimpleCacheProbability);
+ trial->AppendGroup("ExperimentYes", kSimpleCacheProbability);
+ trial->AppendGroup("ExperimentControl", kSimpleCacheProbability);
trial->group();
}
#endif
« no previous file with comments | « no previous file | net/disk_cache/cache_creator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698