Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 14048011: Add some missing includes for IO functions. (Closed)

Created:
7 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@speech-dispatcher-version-fix
Visibility:
Public.

Description

Add some missing includes for IO functions. The build was failing on GCC 4.8.0 and glibc 2.17 because unistd.h was not being included despite read(2), pipe(2), write(2) and close(2) being used. BUG= TEST=Try to build using the setup described above. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194863

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch v2 #

Patch Set 3 : Add myself to AUTHORS #

Patch Set 4 : Resolve conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/flip_server/epoll_server.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/flip_server/sm_connection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Raphael Kubo da Costa (rakuco)
7 years, 8 months ago (2013-04-17 12:12:34 UTC) #1
brettw
I defer to ricardo
7 years, 8 months ago (2013-04-17 18:04:17 UTC) #2
rvargas (doing something else)
Please add yourself to the AUTHORS file. Thanks. https://codereview.chromium.org/14048011/diff/1/net/tools/flip_server/epoll_server.cc File net/tools/flip_server/epoll_server.cc (right): https://codereview.chromium.org/14048011/diff/1/net/tools/flip_server/epoll_server.cc#newcode11 net/tools/flip_server/epoll_server.cc:11: #include ...
7 years, 8 months ago (2013-04-17 18:08:26 UTC) #3
Raphael Kubo da Costa (rakuco)
On 2013/04/17 18:08:26, rvargas wrote: > Please add yourself to the AUTHORS file. > > ...
7 years, 8 months ago (2013-04-17 18:19:55 UTC) #4
rvargas (doing something else)
On 2013/04/17 18:19:55, Raphael Kubo da Costa (rakuco) wrote: > On 2013/04/17 18:08:26, rvargas wrote: ...
7 years, 8 months ago (2013-04-17 18:46:39 UTC) #5
Raphael Kubo da Costa (rakuco)
On 2013/04/17 18:46:39, rvargas wrote: > That CL _looks_ like adding a new dependency to ...
7 years, 8 months ago (2013-04-17 19:12:14 UTC) #6
rvargas (doing something else)
lgtm
7 years, 8 months ago (2013-04-17 19:24:56 UTC) #7
Raphael Kubo da Costa (rakuco)
On 2013/04/17 19:24:56, rvargas wrote: > lgtm Thank you very much. Any chance of getting ...
7 years, 8 months ago (2013-04-17 19:44:02 UTC) #8
rvargas (doing something else)
On 2013/04/17 19:44:02, Raphael Kubo da Costa (rakuco) wrote: > On 2013/04/17 19:24:56, rvargas wrote: ...
7 years, 8 months ago (2013-04-17 21:00:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/14048011/9001
7 years, 8 months ago (2013-04-18 07:26:03 UTC) #10
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-18 07:26:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/14048011/9001
7 years, 8 months ago (2013-04-18 07:28:11 UTC) #12
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-18 07:28:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/14048011/18001
7 years, 8 months ago (2013-04-18 07:30:51 UTC) #14
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 09:22:02 UTC) #15
Message was sent while issue was closed.
Change committed as 194863

Powered by Google App Engine
This is Rietveld 408576698