Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 14047009: use commandlineflags for tests/ (Closed)

Created:
7 years, 8 months ago by reed1
Modified:
7 years, 8 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

use commandlineflags for tests/ Committed: http://code.google.com/p/skia/source/detail?r=8616

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -52 lines) Patch
M gyp/tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/skia_test.cpp View 1 5 chunks +23 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
note: might want an option to specify that a given string flag expects exactly 1 ...
7 years, 8 months ago (2013-04-11 15:53:48 UTC) #1
scroggo
> note: might want an option to specify that a given string > flag expects ...
7 years, 8 months ago (2013-04-11 16:28:01 UTC) #2
reed1
done
7 years, 8 months ago (2013-04-11 16:31:21 UTC) #3
scroggo
On 2013/04/11 16:31:21, reed1 wrote: > done lgtm
7 years, 8 months ago (2013-04-11 16:31:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/14047009/4
7 years, 8 months ago (2013-04-11 16:34:41 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-11 16:54:12 UTC) #6
Message was sent while issue was closed.
Change committed as 8616

Powered by Google App Engine
This is Rietveld 408576698