Ready for latest WebIDL for named property getters.

Ready for latest WebIDL for named property getters.

Currently Blink WebIDL is old and defined named property getter
as [NamedGetter], which has a problem that sometimes
we can't get return type and method name via IDL.

This patch improve the situation,
now all existing [NamedGetter] in IDL are replaced with
getter ReturnType MethodName(DOMString) as discribed in:
http://www.w3.org/TR/WebIDL/#idl-named-properties

Note that current generator does not have logic to
generate named setter, creator, deleter code.
This is one of TODOs.

R=haraken@chromium.org
BUG=229740
TEST=TestEventTarget.idl

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149247

[kojih, 2013-04-26 11:33:03]

r?

[haraken, 2013-04-26 11:47:15]

This is great improvement.

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/Co...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/Co...
Source/bindings/scripts/CodeGeneratorV8.pm:286: and scalar(@$parameters)==1 and
$parameters->[0]->type eq "DOMString" ) {
Here you should just check whether "getter" is contained in @$specials or not.

Then let's assert if the first argument is not DOMString.

The code would be:

my $getterExists = grep { $_ eq "getter" } @$specials;
if ($getterExists) {
  die "..." unless @parameters >= 1 and $parameters->[0]->type eq "DOMString";
  return $function;
}

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/ID...
File Source/bindings/scripts/IDLParser.pm (right):

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/ID...
Source/bindings/scripts/IDLParser.pm:1210: push(@$specials,
$self->parseSpecial());
I think this isn't needed.

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/ID...
Source/bindings/scripts/IDLParser.pm:1216:
$interface->signature->specials($specials);
You can also write:

my @specials = ();
push(@specials, @{$self->parseSpecial});
...
$interface->signature->specials(\@specials);

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/ID...
Source/bindings/scripts/IDLParser.pm:1236: return $specials;
Ditto. You can write:

my @specials = ();
push(@specials, $self->parseSpecial());
...;
return \@specials;

[kojih, 2013-04-26 12:03:24]

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/Co...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/Co...
Source/bindings/scripts/CodeGeneratorV8.pm:286: and scalar(@$parameters)==1 and
$parameters->[0]->type eq "DOMString" ) {
OK for getter.
regarding assert DOMString, I'll support also indexed property getter.
In that case, argument is one unsigned long.
So I think can't assert it should be DOMString.

http://www.w3.org/TR/WebIDL/#idl-indexed-properties

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/ID...
File Source/bindings/scripts/IDLParser.pm (right):

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/ID...
Source/bindings/scripts/IDLParser.pm:1216:
$interface->signature->specials($specials);
I like that style, but it's OK :)

[haraken, 2013-04-26 12:09:52]

LGTM!

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/ID...
File Source/bindings/scripts/IDLParser.pm (right):

https://codereview.chromium.org/14044026/diff/1011/Source/bindings/scripts/ID...
Source/bindings/scripts/IDLParser.pm:1216:
$interface->signature->specials($specials);
On 2013/04/26 12:03:24, kojih wrote:
> I like that style, but it's OK :)

Other parts of IDLParser.pm uses 'my @foo=...' style, so let's use it here.

https://codereview.chromium.org/14044026/diff/15001/Source/bindings/scripts/C...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/14044026/diff/15001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:286: if ($getterExists and
scalar(@$parameters)==1 and $parameters->[0]->type eq "DOMString" ) {
Nit: Spaces needed around '=='

[commit-bot: I haz the power, 2013-04-26 12:16:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/14044026/17002

[commit-bot: I haz the power, 2013-04-26 12:16:29]

Presubmit check for 14044026-17002 failed and returned exit status 1.

INFO:root:Found 11 file(s).
Running presubmit commit checks ...
Running /b/commit-queue/workdir/blink/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    Source/modules/mediastream/RTCStatsResponse.idl

Presubmit checks took 1.5s to calculate.

[haraken, 2013-04-26 12:18:22]

> Missing LGTM from an OWNER for these files:
>     Source/modules/mediastream/RTCStatsResponse.idl

^^^ Sorry, this is a bug of the cq-bot.

jochen: rubber-stamp please?

[abarth-chromium, 2013-04-26 22:10:18]

LGTM.

We need to fix the per-file IDL OWNER issue.

@haraken maybe we should make you an OWNER in Source/modules until that issue is
resolved.

[commit-bot: I haz the power, 2013-04-27 05:07:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/14044026/17002

[commit-bot: I haz the power, 2013-04-27 05:31:08]

Change committed as 149247