Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 14037008: App and Extension Documentation: Don't forbid non-standard icon sizes. (Closed)

Created:
7 years, 8 months ago by Matt Giuca
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, Andy
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

App and Extension Documentation: Don't forbid non-standard icon sizes. Now it explicitly says that apps and extensions may use any size of icon, but still recommends certain basic sizes, in particular 128x128. BUG=230281 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194776

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M chrome/common/extensions/docs/templates/articles/manifest.html View 1 chunk +5 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Matt Giuca
Hi Matt, Running this by you first before sending the CL to docs people for ...
7 years, 8 months ago (2013-04-12 06:39:44 UTC) #1
Matt Perry
OK, I agree this is clearer. LGTM
7 years, 8 months ago (2013-04-12 18:41:25 UTC) #2
Matt Giuca
7 years, 8 months ago (2013-04-12 23:32:12 UTC) #3
Matt Giuca
On 2013/04/12 23:32:12, Matt Giuca wrote: Meggin: Friendly ping. (Maybe I didn't send mail properly?)
7 years, 8 months ago (2013-04-17 05:56:37 UTC) #4
mkearney1
lgtm
7 years, 8 months ago (2013-04-17 19:13:29 UTC) #5
mkearney
Hey, Matt LGTM just sent your way. Meggin On Tue, Apr 16, 2013 at 10:56 ...
7 years, 8 months ago (2013-04-17 19:13:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/14037008/1
7 years, 8 months ago (2013-04-18 00:23:32 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-18 00:26:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/14037008/1
7 years, 8 months ago (2013-04-18 02:09:51 UTC) #9
Matt Giuca
Thanks, Matt and Meggin.
7 years, 8 months ago (2013-04-18 02:09:58 UTC) #10
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 05:14:35 UTC) #11
Message was sent while issue was closed.
Change committed as 194776

Powered by Google App Engine
This is Rietveld 408576698