Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 14037005: Improve app.window documentation (Closed)

Created:
7 years, 8 months ago by benwells
Modified:
7 years, 7 months ago
Reviewers:
jeremya
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, mkearney1
Visibility:
Public.

Description

Improve app.window documentation The documentation was out of date, as there is now no way to have default versus specific bounds. Instead all supplied bounds are default. BUG=230606 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198815

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M chrome/common/extensions/api/app_window.idl View 1 3 chunks +16 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
benwells
7 years, 8 months ago (2013-04-12 05:17:06 UTC) #1
jeremya
lgtm https://codereview.chromium.org/14037005/diff/1/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/14037005/diff/1/chrome/common/extensions/api/app_window.idl#newcode76 chrome/common/extensions/api/app_window.idl:76: // parameters, this field takes precedence. Perhaps we ...
7 years, 8 months ago (2013-04-12 17:09:07 UTC) #2
jeremya
+mkearney
7 years, 8 months ago (2013-04-12 21:37:14 UTC) #3
benwells
https://codereview.chromium.org/14037005/diff/1/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/14037005/diff/1/chrome/common/extensions/api/app_window.idl#newcode76 chrome/common/extensions/api/app_window.idl:76: // parameters, this field takes precedence. On 2013/04/12 17:09:07, ...
7 years, 7 months ago (2013-05-07 11:43:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/14037005/5001
7 years, 7 months ago (2013-05-07 11:44:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=124868
7 years, 7 months ago (2013-05-07 12:00:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/14037005/5001
7 years, 7 months ago (2013-05-07 21:30:57 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 22:26:28 UTC) #8
Message was sent while issue was closed.
Change committed as 198815

Powered by Google App Engine
This is Rietveld 408576698