Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 14034018: Some fixes for saturation computation XferEffect. (Closed)

Created:
7 years, 8 months ago by bsalomon
Modified:
7 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove redundant setting of alpha in hard-light GPU shader.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/core/SkXfermode.cpp View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
I don't know why this affected the PVR devices only. These are real fixes obviously ...
7 years, 8 months ago (2013-04-24 21:18:54 UTC) #1
robertphillips
lgtm
7 years, 8 months ago (2013-04-24 21:42:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/14034018/1
7 years, 8 months ago (2013-04-25 00:36:15 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-25 00:40:44 UTC) #4
Message was sent while issue was closed.
Change committed as 8850

Powered by Google App Engine
This is Rietveld 408576698