Issue 14034014: path ops -- use standard SkTQSort

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14034014: path ops -- use standard SkTQSort (Closed)

Created:
7 years, 8 months ago by caryclark

Modified:
7 years, 8 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

path ops -- use standard SkTQSort thanks to bungeman for the contextual sort Committed: http://code.google.com/p/skia/source/detail?r=8810

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -117 lines)			Patch
M	src/pathops/SkDCubicIntersection.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pathops/SkDCubicToQuads.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pathops/SkDQuadIntersection.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pathops/SkOpAngle.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pathops/SkOpContour.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pathops/SkPathOpsCommon.cpp	View	1	3 chunks	+12 lines, -6 lines	2 comments	Download
D	src/pathops/TSearch.h	View		1 chunk	+0 lines, -101 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

lgtm, except for some minor nits in the code I touched :-) https://codereview.chromium.org/14034014/diff/2002/src/pathops/SkPathOpsCommon.cpp File src/pathops/SkPathOpsCommon.cpp ...

7 years, 8 months ago (2013-04-22 16:00:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/14034014/2002

7 years, 8 months ago (2013-04-22 16:16:36 UTC) #3

Message was sent while issue was closed.

Change committed as 8810

Expand Messages | Collapse Messages