chrome/installer/util/chrome_app_host_operations.cc - Issue 14031025: Implementing unified Chrome / App Launcher flow, and migrating old stand-alone App Launcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/chrome_app_host_operations.cc

Issue 14031025: Implementing unified Chrome / App Launcher flow, and migrating old stand-alone App Launcher. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feature-complete (except for unit tests for ShellUtil shortcut update code). Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/util/chrome_app_host_distribution.cc ('K') | « chrome/installer/util/chrome_app_host_distribution.cc ('k') | chrome/installer/util/installation_validator.cc » ('j') | chrome/installer/util/installer_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/chrome_app_host_operations.cc

diff --git a/chrome/installer/util/chrome_app_host_operations.cc b/chrome/installer/util/chrome_app_host_operations.cc

index 361f952ef10e612e6fbc4a2e4a58bf251e60ece5..9479aa2236c444955bed818dad319f9d9232d867 100644

--- a/chrome/installer/util/chrome_app_host_operations.cc

+++ b/chrome/installer/util/chrome_app_host_operations.cc

@@ -83,7 +83,8 @@ bool ChromeAppHostOperations::SetChannelFlags(const std::set<string16>& options,

ChannelInfo* channel_info) const {

#if defined(GOOGLE_CHROME_BUILD)

DCHECK(channel_info);

- return channel_info->SetAppLauncher(set);

+ // Force App Launcher to be absent from "ap" values.

+ return channel_info->SetAppLauncher(false);

#else

return false;

#endif

@@ -91,7 +92,7 @@ bool ChromeAppHostOperations::SetChannelFlags(const std::set<string16>& options,

bool ChromeAppHostOperations::ShouldCreateUninstallEntry(

const std::set<string16>& options) const {

- return true;

+ return false;

}

void ChromeAppHostOperations::AddDefaultShortcutProperties(