Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14030004: Added DriveNotificationManagerFactory so DriveNotificationManager is a singleton and can be called … (Closed)

Created:
7 years, 8 months ago by calvinlo
Modified:
7 years, 8 months ago
Reviewers:
Lei Zhang, kinaba, satorux1, tzik
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Added DriveNotificationManagerFactory so DriveNotificationManager is a singleton and can be called statically. BUG=173339 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194282

Patch Set 1 #

Total comments: 4

Patch Set 2 : Satorux #1 review, added class comment and updated DEPS #

Total comments: 2

Patch Set 3 : Revised factory dependencies, also DEPS updated correspondingly #

Patch Set 4 : Typo fix for compile #

Total comments: 2

Patch Set 5 : fix DEPS empty line #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2 lines) Patch
M chrome/browser/google_apis/DEPS View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/google_apis/drive_notification_manager_factory.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/google_apis/drive_notification_manager_factory.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_factory.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
calvinlo
+thestig for chrome_browser.gypi review +tzik for review
7 years, 8 months ago (2013-04-11 02:40:43 UTC) #1
Lei Zhang
https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h File chrome/browser/google_apis/drive_notification_manager_factory.h (right): https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h#newcode9 chrome/browser/google_apis/drive_notification_manager_factory.h:9: #include "chrome/browser/profiles/profile_keyed_service_factory.h" Isn't bug 146989 trying to get you ...
7 years, 8 months ago (2013-04-11 02:49:58 UTC) #2
calvinlo
On 2013/04/11 02:49:58, Lei Zhang wrote: > https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h > File chrome/browser/google_apis/drive_notification_manager_factory.h (right): > > https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h#newcode9 ...
7 years, 8 months ago (2013-04-11 03:24:56 UTC) #3
calvinlo
https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h File chrome/browser/google_apis/drive_notification_manager_factory.h (right): https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h#newcode9 chrome/browser/google_apis/drive_notification_manager_factory.h:9: #include "chrome/browser/profiles/profile_keyed_service_factory.h" On 2013/04/11 02:49:58, Lei Zhang wrote: > ...
7 years, 8 months ago (2013-04-11 04:05:33 UTC) #4
satorux1
https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h File chrome/browser/google_apis/drive_notification_manager_factory.h (right): https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h#newcode15 chrome/browser/google_apis/drive_notification_manager_factory.h:15: class DriveNotificationManagerFactory : public ProfileKeyedServiceFactory { Class comment is ...
7 years, 8 months ago (2013-04-11 05:27:54 UTC) #5
calvinlo
https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h File chrome/browser/google_apis/drive_notification_manager_factory.h (right): https://codereview.chromium.org/14030004/diff/1/chrome/browser/google_apis/drive_notification_manager_factory.h#newcode15 chrome/browser/google_apis/drive_notification_manager_factory.h:15: class DriveNotificationManagerFactory : public ProfileKeyedServiceFactory { On 2013/04/11 05:27:54, ...
7 years, 8 months ago (2013-04-11 05:41:15 UTC) #6
satorux1
LGTM
7 years, 8 months ago (2013-04-11 05:43:36 UTC) #7
tzik
https://codereview.chromium.org/14030004/diff/6002/chrome/browser/google_apis/drive_notification_manager_factory.cc File chrome/browser/google_apis/drive_notification_manager_factory.cc (right): https://codereview.chromium.org/14030004/diff/6002/chrome/browser/google_apis/drive_notification_manager_factory.cc#newcode27 chrome/browser/google_apis/drive_notification_manager_factory.cc:27: ProfileDependencyManager::GetInstance()) {} I think the DriveNotificationManager depends some other ...
7 years, 8 months ago (2013-04-11 05:48:17 UTC) #8
Lei Zhang
On 2013/04/11 05:43:36, satorux1 wrote: > LGTM .gypi lgtm since you are ok with adding ...
7 years, 8 months ago (2013-04-11 06:02:54 UTC) #9
calvinlo
Satoru, can you please check the DEPS update. It seems like I've had to add ...
7 years, 8 months ago (2013-04-11 06:47:33 UTC) #10
tzik
lgtm
7 years, 8 months ago (2013-04-11 08:06:48 UTC) #11
calvinlo
+kinaba, can you please double check the exceptions added to DEPS. I think Satoru checked ...
7 years, 8 months ago (2013-04-12 02:20:34 UTC) #12
kinaba
> +kinaba, can you please double check the exceptions added to DEPS. lgtm https://codereview.chromium.org/14030004/diff/17001/chrome/browser/google_apis/DEPS File ...
7 years, 8 months ago (2013-04-12 03:19:21 UTC) #13
calvinlo
https://codereview.chromium.org/14030004/diff/17001/chrome/browser/google_apis/DEPS File chrome/browser/google_apis/DEPS (right): https://codereview.chromium.org/14030004/diff/17001/chrome/browser/google_apis/DEPS#newcode22 chrome/browser/google_apis/DEPS:22: On 2013/04/12 03:19:21, kinaba wrote: > nit: no blank ...
7 years, 8 months ago (2013-04-12 03:43:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/14030004/26001
7 years, 8 months ago (2013-04-12 03:45:17 UTC) #15
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-12 05:32:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/14030004/41001
7 years, 8 months ago (2013-04-12 05:53:38 UTC) #17
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=40514
7 years, 8 months ago (2013-04-12 06:34:40 UTC) #18
calvinlo
7 years, 8 months ago (2013-04-16 03:00:42 UTC) #19
Message was sent while issue was closed. 
Committed patchset #6 manually as r194282 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698