Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc

Issue 14028005: Update locally managed user creation flow according to mocks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use global cancel button Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc
diff --git a/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc b/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc
index 55110a6d9fc94f87bee61da0452f26e868f5f9e2..6130213cc4c91726115223d1fa8ab10042a24089 100644
--- a/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc
+++ b/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc
@@ -73,9 +73,9 @@ void LocallyManagedUserCreationScreen::Show() {
// TODO(antrim) : temorary hack (until upcoming hackaton). Should be
// removed once we have screens reworked.
if (on_image_screen_) {
ygorshenin1 2013/04/12 12:49:35 nit: you can omit curly braces here
- actor_->ShowPostImageSelectionScreen();
+ actor_->ShowTutorialPage();
} else {
- actor_->ShowInitialScreen();
+ actor_->ShowIntroPage();
}
}
@@ -105,7 +105,7 @@ void LocallyManagedUserCreationScreen::
ShowManagerInconsistentStateErrorScreen() {
if (!actor_)
return;
- actor_->ShowErrorMessage(
+ actor_->ShowErrorPage(
l10n_util::GetStringUTF16(
IDS_CREATE_LOCALLY_MANAGED_USER_MANAGER_INCONSISTENT_STATE),
false);
@@ -113,7 +113,7 @@ void LocallyManagedUserCreationScreen::
void LocallyManagedUserCreationScreen::ShowInitialScreen() {
if (actor_)
- actor_->ShowInitialScreen();
+ actor_->ShowIntroPage();
}
void LocallyManagedUserCreationScreen::Hide() {
@@ -136,20 +136,12 @@ void LocallyManagedUserCreationScreen::FinishFlow() {
controller_->FinishCreation();
}
-void LocallyManagedUserCreationScreen::RetryLastStep() {
- controller_->RetryLastStep();
-}
-
-void LocallyManagedUserCreationScreen::RunFlow(
- string16& display_name,
- std::string& managed_user_password,
+void LocallyManagedUserCreationScreen::AuthenticateManager(
std::string& manager_id,
std::string& manager_password) {
-
// Make sure no two controllers exist at the same time.
controller_.reset();
controller_.reset(new LocallyManagedUserController(this));
- controller_->SetUpCreation(display_name, managed_user_password);
ExistingUserController::current_controller()->
Login(UserContext(manager_id,
@@ -157,15 +149,27 @@ void LocallyManagedUserCreationScreen::RunFlow(
std::string() /* auth_code */));
}
+void LocallyManagedUserCreationScreen::CreateManagedUser(
+ string16& display_name,
+ std::string& managed_user_password) {
+ DCHECK(controller_.get());
+ controller_->SetUpCreation(display_name, managed_user_password);
+ controller_->StartCreation();
+}
+
void LocallyManagedUserCreationScreen::OnManagerLoginFailure() {
if (actor_)
actor_->ShowManagerPasswordError();
}
-void LocallyManagedUserCreationScreen::OnManagerSignIn() {
+void LocallyManagedUserCreationScreen::OnManagerFullyAuthenticated() {
if (actor_)
- actor_->ShowProgressScreen();
- controller_->StartCreation();
+ actor_->ShowUsernamePage();
+}
+
+void LocallyManagedUserCreationScreen::OnManagerCryptohomeAuthenticated() {
+ if (actor_)
+ actor_->ShowProgressPage();
}
void LocallyManagedUserCreationScreen::OnExit() {}
@@ -205,7 +209,7 @@ void LocallyManagedUserCreationScreen::OnCreationError(
NOTREACHED();
}
if (actor_)
- actor_->ShowErrorMessage(message, recoverable);
+ actor_->ShowErrorPage(message, recoverable);
}
void LocallyManagedUserCreationScreen::SelectPicture() {

Powered by Google App Engine
This is Rietveld 408576698