Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3105)

Unified Diff: appengine/middleware/appengine_test.go

Issue 1402543003: Add initial middleware package. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/middleware/appengine.go ('k') | appengine/middleware/context.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/middleware/appengine_test.go
diff --git a/appengine/middleware/appengine_test.go b/appengine/middleware/appengine_test.go
new file mode 100644
index 0000000000000000000000000000000000000000..04922a66566ada9d627ff01330897adb5846a716
--- /dev/null
+++ b/appengine/middleware/appengine_test.go
@@ -0,0 +1,116 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package middleware
+
+import (
+ "net/http"
+ "net/http/httptest"
+ "testing"
+
+ "github.com/julienschmidt/httprouter"
+ . "github.com/smartystreets/goconvey/convey"
+ "golang.org/x/net/context"
+)
+
+func init() {
+ // disable this so that we can actually check the logic in these middlewares
+ devAppserverBypassFn = func(context.Context) bool { return false }
+}
+
+func TestRequireCron(t *testing.T) {
+ t.Parallel()
+
+ Convey("Test RequireCron", t, func() {
+ hit := false
+ f := func(c context.Context, rw http.ResponseWriter, r *http.Request, p httprouter.Params) {
+ hit = true
+ rw.Write([]byte("ok"))
+ }
+
+ Convey("from non-cron fails", func() {
+ rec := httptest.NewRecorder()
+ BaseTest(RequireCron(f))(rec, &http.Request{}, nil)
+ So(hit, ShouldBeFalse)
+ So(rec.Body.String(), ShouldEqual, "error: must be run from cron")
+ So(rec.Code, ShouldEqual, http.StatusForbidden)
+ })
+
+ Convey("from cron succeeds", func() {
+ rec := httptest.NewRecorder()
+ BaseTest(RequireCron(f))(rec, &http.Request{
+ Header: http.Header{
+ http.CanonicalHeaderKey("x-appengine-cron"): []string{"true"},
+ },
+ }, nil)
+ So(hit, ShouldBeTrue)
+ So(rec.Body.String(), ShouldEqual, "ok")
+ So(rec.Code, ShouldEqual, http.StatusOK)
+ })
+ })
+}
+
+func TestRequireTQ(t *testing.T) {
+ t.Parallel()
+
+ Convey("Test RequireTQ", t, func() {
+ hit := false
+ f := func(c context.Context, rw http.ResponseWriter, r *http.Request, p httprouter.Params) {
+ hit = true
+ rw.Write([]byte("ok"))
+ }
+
+ Convey("from non-tq fails (wat)", func() {
+ rec := httptest.NewRecorder()
+ BaseTest(RequireTaskQueue("wat", f))(rec, &http.Request{}, nil)
+ So(hit, ShouldBeFalse)
+ So(rec.Body.String(), ShouldEqual, "error: must be run from the correct taskqueue")
+ So(rec.Code, ShouldEqual, http.StatusForbidden)
+ })
+
+ Convey("from non-tq fails", func() {
+ rec := httptest.NewRecorder()
+ BaseTest(RequireTaskQueue("", f))(rec, &http.Request{}, nil)
+ So(hit, ShouldBeFalse)
+ So(rec.Body.String(), ShouldEqual, "error: must be run from the correct taskqueue")
+ So(rec.Code, ShouldEqual, http.StatusForbidden)
+ })
+
+ Convey("from wrong tq fails (wat)", func() {
+ rec := httptest.NewRecorder()
+ BaseTest(RequireTaskQueue("wat", f))(rec, &http.Request{
+ Header: http.Header{
+ http.CanonicalHeaderKey("x-appengine-queuename"): []string{"else"},
+ },
+ }, nil)
+ So(hit, ShouldBeFalse)
+ So(rec.Body.String(), ShouldEqual, "error: must be run from the correct taskqueue")
+ So(rec.Code, ShouldEqual, http.StatusForbidden)
+ })
+
+ Convey("from right tq succeeds (wat)", func() {
+ rec := httptest.NewRecorder()
+ BaseTest(RequireTaskQueue("wat", f))(rec, &http.Request{
+ Header: http.Header{
+ http.CanonicalHeaderKey("x-appengine-queuename"): []string{"wat"},
+ },
+ }, nil)
+ So(hit, ShouldBeTrue)
+ So(rec.Body.String(), ShouldEqual, "ok")
+ So(rec.Code, ShouldEqual, http.StatusOK)
+ })
+
+ Convey("from any tq succeeds", func() {
+ rec := httptest.NewRecorder()
+ BaseTest(RequireTaskQueue("", f))(rec, &http.Request{
+ Header: http.Header{
+ http.CanonicalHeaderKey("x-appengine-queuename"): []string{"wat"},
+ },
+ }, nil)
+ So(hit, ShouldBeTrue)
+ So(rec.Body.String(), ShouldEqual, "ok")
+ So(rec.Code, ShouldEqual, http.StatusOK)
+ })
+ })
+}
« no previous file with comments | « appengine/middleware/appengine.go ('k') | appengine/middleware/context.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698