Chromium Code Reviews
Help | Chromium Project | Sign in
(483)

Issue 14021010: Add file association for .webp to Chrome. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 3 weeks ago by Stephen
Modified:
11 months, 3 weeks ago
Reviewers:
gab, grt
CC:
chromium-reviews_chromium.org, grt+watch_chromium.org
Visibility:
Public.

Description

Add file association for .webp to Chrome.
This CL will enable Chrome to be a registered handler for .webp files
on Windows.

BUG=234275
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197423

Patch Set 1 #

Patch Set 2 : Added L prefix #

Patch Set 3 : Separated default from non-default file associations #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : Renamed kFileAssociations to kDefaultFileAssociations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Lint Patch
M chrome/installer/setup/uninstall.cc View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments ? errors Download
M chrome/installer/util/shell_util.h View 1 2 3 4 5 1 chunk +7 lines, -2 lines 0 comments ? errors Download
M chrome/installer/util/shell_util.cc View 1 2 3 4 5 5 chunks +14 lines, -11 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 10
Stephen
PTAL.
11 months, 3 weeks ago #1
grt
The bug says to register Chrome as the default if nothing else is registered. I ...
11 months, 3 weeks ago #2
Stephen
On 2013/04/27 00:54:38, grt wrote: > The bug says to register Chrome as the default ...
11 months, 3 weeks ago #3
Stephen
OK, please take another look. I took a similar approach to BrowserProtocolAssociations/PotentialBrowserProtocolAssociations by creating two ...
11 months, 3 weeks ago #4
gab
lgtm, note however that this will require Chrome to re-register. This happens on update, unless ...
11 months, 3 weeks ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skonig@chromium.org/14021010/22001
11 months, 3 weeks ago #6
Stephen
https://chromiumcodereview.appspot.com/14021010/diff/15001/chrome/installer/util/shell_util.cc File chrome/installer/util/shell_util.cc (right): https://chromiumcodereview.appspot.com/14021010/diff/15001/chrome/installer/util/shell_util.cc#newcode1223 chrome/installer/util/shell_util.cc:1223: const wchar_t* ShellUtil::kFileAssociations[] = {L".htm", L".html", L".shtml", On 2013/04/29 ...
11 months, 3 weeks ago #7
I haz the power (commit-bot)
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=36483
11 months, 3 weeks ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skonig@chromium.org/14021010/22001
11 months, 3 weeks ago #9
I haz the power (commit-bot)
11 months, 3 weeks ago #10
Message was sent while issue was closed.
Change committed as 197423
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6