Add file association for .webp to Chrome.

Add file association for .webp to Chrome.
This CL will enable Chrome to be a registered handler for .webp files
on Windows.

BUG=234275
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197423

[Stephen, 2013-04-26 21:02:01]

PTAL.

[grt (UTC plus 2), 2013-04-27 00:54:38]

The bug says to register Chrome as the default if nothing else is registered. I
believe that this patch as-is will make Chrome overtake another program if
Chrome is made the user's default *web browser* by way of chrome://settings or
the default browser infobar. Is this intended?

[Stephen, 2013-04-27 03:06:04]

On 2013/04/27 00:54:38, grt wrote:
> The bug says to register Chrome as the default if nothing else is registered.
I
> believe that this patch as-is will make Chrome overtake another program if
> Chrome is made the user's default *web browser* by way of chrome://settings or
> the default browser infobar. Is this intended?

No, good point.  We want Chrome to be registered as a handler for .webp, but not
to overtake default status (that would be annoying if the user did have another
program like an image editor set as the default handler).  I will update this to
reflect that.

[Stephen, 2013-04-28 23:44:09]

OK, please take another look.  I took a similar approach to
BrowserProtocolAssociations/PotentialBrowserProtocolAssociations by creating two
lists of file associations.  The original list of file associations is
unchanged; these will be the ones that Chrome is registered as the default
hander for when Chrome is made default.  The potential list of file associations
is used when registering with the shell for "open as", and includes all entries
in the former list plus ".webp".  In the future we can extend the potential list
to allow Chrome to open up other file types  (e.g., other image or media files)
without trampling on the default when Chrome is set as the default browser.  I'm
leaving that up to a future CL.

[gab, 2013-04-29 21:15:04]

lgtm, note however that this will require Chrome to re-register. This happens on
update, unless we update a user-level install of Chrome on Win7- (only Windows 8
allows those registrations to be in HKCU; thus we need admin rights to write
them on previous versions of Windows, but the update runs without admin rights
for user-level installs)...

For users which do not get the new registrations, this will not work until they
do (by triggering Chrome to make itself default again, at which point it will
elevate to finish registration...).

If this is a concern, it might be a good idea to add a button in settings, where
we state that "The default browser is currently Google Chrome.", to "Google
Chrome is your default browser, but needs to update some registry settings which
require admin rights..." (this is obviously not a user-friendly sentence, but
you get the idea :)!

Cheers!
Gab

https://chromiumcodereview.appspot.com/14021010/diff/15001/chrome/installer/u...
File chrome/installer/util/shell_util.cc (right):

https://chromiumcodereview.appspot.com/14021010/diff/15001/chrome/installer/u...
chrome/installer/util/shell_util.cc:1223: const wchar_t*
ShellUtil::kFileAssociations[] = {L".htm", L".html", L".shtml",
nit: Please rename this to kDefaultFileAssociations and add a comment to explain
the difference (i.e. the former list is used to explicitly set default Chrome as
default for those file types when Chrome is made default browser; the latter
list is used to register Chrome as a valid handler for those file types).

[commit-bot: I haz the power, 2013-04-30 04:06:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skonig@chromium.org/14021010/22001

[Stephen, 2013-04-30 04:08:37]

https://chromiumcodereview.appspot.com/14021010/diff/15001/chrome/installer/u...
File chrome/installer/util/shell_util.cc (right):

https://chromiumcodereview.appspot.com/14021010/diff/15001/chrome/installer/u...
chrome/installer/util/shell_util.cc:1223: const wchar_t*
ShellUtil::kFileAssociations[] = {L".htm", L".html", L".shtml",
On 2013/04/29 21:15:04, gab wrote:
> nit: Please rename this to kDefaultFileAssociations and add a comment to
explain
> the difference (i.e. the former list is used to explicitly set default Chrome
as
> default for those file types when Chrome is made default browser; the latter
> list is used to register Chrome as a valid handler for those file types).

Done.

[commit-bot: I haz the power, 2013-04-30 05:09:19]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-04-30 17:35:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skonig@chromium.org/14021010/22001

[commit-bot: I haz the power, 2013-04-30 19:25:54]

Change committed as 197423