Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 14021004: Revert r14310 due to isolate tests failure. (Closed)

Created:
7 years, 8 months ago by Yang
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Revert r14310 due to isolate tests failure. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -353 lines) Patch
M src/d8.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/d8.cc View 22 chunks +76 lines, -278 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/bugs/bug-proto.js View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 8 months ago (2013-04-18 14:40:29 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 8 months ago (2013-04-18 14:40:59 UTC) #2
Yang
7 years, 8 months ago (2013-04-18 14:41:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698