src/v8utils.cc - Issue 14018010: Fix OOB write in --print-code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8utils.cc

Issue 14018010: Fix OOB write in --print-code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/v8utils.cc

diff --git a/src/v8utils.cc b/src/v8utils.cc

index 58ad4e5edd5262b7dba1e67c769250e090ac3af1..8d97f54b81f40765b900310da4c120116846397f 100644

--- a/src/v8utils.cc

+++ b/src/v8utils.cc

@@ -264,7 +264,7 @@ void StringBuilder::AddFormatted(const char* format, ...) {

void StringBuilder::AddFormattedList(const char* format, va_list list) {

- ASSERT(!is_finalized() && position_ < buffer_.length());

+ ASSERT(!is_finalized() && position_ <= buffer_.length());

int n = OS::VSNPrintF(buffer_ + position_, format, list);

if (n < 0 || n >= (buffer_.length() - position_)) {

position_ = buffer_.length();

« no previous file with comments | « src/utils.cc ('k') | test/mjsunit/regress/regress-2624.js » ('j') | no next file with comments »