Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/disassembler.cc

Issue 14018010: Fix OOB write in --print-code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/utils.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 static void DumpBuffer(FILE* f, StringBuilder* out) { 100 static void DumpBuffer(FILE* f, StringBuilder* out) {
101 if (f == NULL) { 101 if (f == NULL) {
102 PrintF("%s\n", out->Finalize()); 102 PrintF("%s\n", out->Finalize());
103 } else { 103 } else {
104 PrintF(f, "%s\n", out->Finalize()); 104 PrintF(f, "%s\n", out->Finalize());
105 } 105 }
106 out->Reset(); 106 out->Reset();
107 } 107 }
108 108
109 109
110
111 static const int kOutBufferSize = 2048 + String::kMaxShortPrintLength; 110 static const int kOutBufferSize = 2048 + String::kMaxShortPrintLength;
112 static const int kRelocInfoPosition = 57; 111 static const int kRelocInfoPosition = 57;
113 112
114 static int DecodeIt(Isolate* isolate, 113 static int DecodeIt(Isolate* isolate,
115 FILE* f, 114 FILE* f,
116 const V8NameConverter& converter, 115 const V8NameConverter& converter,
117 byte* begin, 116 byte* begin,
118 byte* end) { 117 byte* end) {
119 NoHandleAllocation ha(isolate); 118 NoHandleAllocation ha(isolate);
120 AssertNoAllocation no_alloc; 119 AssertNoAllocation no_alloc;
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 352
354 void Disassembler::Dump(FILE* f, byte* begin, byte* end) {} 353 void Disassembler::Dump(FILE* f, byte* begin, byte* end) {}
355 int Disassembler::Decode(Isolate* isolate, FILE* f, byte* begin, byte* end) { 354 int Disassembler::Decode(Isolate* isolate, FILE* f, byte* begin, byte* end) {
356 return 0; 355 return 0;
357 } 356 }
358 void Disassembler::Decode(FILE* f, Code* code) {} 357 void Disassembler::Decode(FILE* f, Code* code) {}
359 358
360 #endif // ENABLE_DISASSEMBLER 359 #endif // ENABLE_DISASSEMBLER
361 360
362 } } // namespace v8::internal 361 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698