browser: Fix null ANativeWindow reference.

browser: Fix null ANativeWindow reference.

On certain Android builds, ANativeWindow_fromSurface
will fail during startup, and we we don't handle this
failure.

BUG=230359
NOTRY=true

No try, since it's Android only.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194773

[epenner, 2013-04-18 00:20:15]

Ptal. Not sure why this only happens on certain Android builds. Perhaps the
initial welcome screen destroys our surface before we can use it?  In any event
it looks like we should handle it being NULL.

[no sievers, 2013-04-18 01:08:50]

lgtm with one comment below.

https://codereview.chromium.org/14017019/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/14017019/diff/1/content/browser/renderer_host...
content/browser/renderer_host/compositor_impl_android.cc:177: {
but don't fall into 'else' here if surface is not null.

[David Trainor- moved to gerrit, 2013-04-18 01:10:34]

lgtm after daniel's comment

[epennerAtGoogle, 2013-04-18 02:03:19]

On 2013/04/18 01:10:34, David Trainor wrote:
> lgtm after daniel's comment

I did a bit more extensive clean-up.

The old SetSurface required SetSurface(NULL) first, or it would leak references
to the old surfaces. Now it cleans up the old surface first (always), followed
by setting the new one (if both the surface and window are valid).

[epennerAtGoogle, 2013-04-18 02:08:20]

I'm going to land, but please double check. I can follow up if there is any
issues.

[commit-bot: I haz the power, 2013-04-18 02:08:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/14017019/6001

[no sievers, 2013-04-18 02:45:33]

Thanks, looks even better :)

[commit-bot: I haz the power, 2013-04-18 03:16:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/14017019/6001

[commit-bot: I haz the power, 2013-04-18 05:03:08]

Change committed as 194773