Issue 14017017: Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14017017: Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts. (Closed)

Created:
7 years, 8 months ago by Finnur

Modified:
7 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, tfarina, sail+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts (for Views and GTK). User is still free to override manually. TBR=sky (already reviewed, except for the two line change, see below) BUG=226994 TEST=Automated test included. NOTE: This is the second attempt at landing, with only the ifdefs in accelerator_utils_views.cc added since last attempt (https://codereview.chromium.org/13044014). Tried building it locally where it failed before (on Win Aura and not) and it passed on both. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194962

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -15 lines)			Patch
	M	chrome/browser/extensions/extension_keybinding_apitest.cc	View	1 2	2 chunks	+10 lines, -4 lines	0 comments	Download
	M	chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js	View	1 2	1 chunk	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/14017017/4001

7 years, 8 months ago (2013-04-18 15:26:16 UTC) #1

Finnur

Scott, not sure you care, but I augmented the test just a tiny bit as ...

7 years, 8 months ago (2013-04-19 16:44:29 UTC) #3

Finnur

7 years, 8 months ago (2013-04-19 17:26:21 UTC) #4

Message was sent while issue was closed.

Hmm... Rietveld doesn't like me. Won't let me try the cl or use the commit
queue. Therefore, lets move this discussion to:
https://codereview.chromium.org/14367027/

Expand Messages | Collapse Messages

Issue 14017017: Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Deflaking the test, hopefully. #

Messages