Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14017014: Sends updated event for click on notifications. (Closed)

Created:
7 years, 8 months ago by Jun Mukai
Modified:
7 years, 8 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Sends updated event for click on notifications. BUG=232231 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195159

Patch Set 1 #

Patch Set 2 : rebase to priority-promotion CL #

Patch Set 3 : set upstream #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : add tests #

Total comments: 2

Patch Set 7 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -13 lines) Patch
M ui/message_center/message_center_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/views/message_popup_collection.h View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 2 3 4 5 6 2 chunks +21 lines, -7 lines 0 comments Download
M ui/message_center/views/message_popup_collection_unittest.cc View 1 2 3 4 5 6 chunks +68 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jun Mukai
This CL depends on crrev.com/14139019. Thanks!
7 years, 8 months ago (2013-04-17 23:00:46 UTC) #1
dewittj
Is it possible to make a test for the click-to-close case?
7 years, 8 months ago (2013-04-17 23:10:12 UTC) #2
Jun Mukai
added tests.
7 years, 8 months ago (2013-04-18 02:55:05 UTC) #3
dewittj
lgtm. Thanks for the tests! https://codereview.chromium.org/14017014/diff/11001/ui/message_center/views/message_popup_collection.cc File ui/message_center/views/message_popup_collection.cc (right): https://codereview.chromium.org/14017014/diff/11001/ui/message_center/views/message_popup_collection.cc#newcode406 ui/message_center/views/message_popup_collection.cc:406: // Updated() can be ...
7 years, 8 months ago (2013-04-18 17:40:51 UTC) #4
Jun Mukai
https://codereview.chromium.org/14017014/diff/11001/ui/message_center/views/message_popup_collection.cc File ui/message_center/views/message_popup_collection.cc (right): https://codereview.chromium.org/14017014/diff/11001/ui/message_center/views/message_popup_collection.cc#newcode406 ui/message_center/views/message_popup_collection.cc:406: // Updated() can be called when a notification is ...
7 years, 8 months ago (2013-04-18 20:22:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14017014/22001
7 years, 8 months ago (2013-04-18 20:22:29 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30387
7 years, 8 months ago (2013-04-19 00:15:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14017014/22001
7 years, 8 months ago (2013-04-19 00:25:04 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 13:27:32 UTC) #9
Message was sent while issue was closed. 
Change committed as 195159

Powered by Google App Engine
This is Rietveld 408576698