Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 14017012: Fix non-uniform scale for stroked ellipses (Closed)

Created:
7 years, 8 months ago by jvanverth1
Modified:
7 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix non-uniform scale and stroked ellipses Strokes were not being scaled properly for ellipses -- the view matrix was being reset before the scale factors were being applied. Scaling the stroke has been moved up higher in the process. Also applies some optimizations suggested by robertphillips. Committed: http://code.google.com/p/skia/source/detail?r=8777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvanverth1
7 years, 8 months ago (2013-04-17 21:10:13 UTC) #1
robertphillips
lgtm
7 years, 8 months ago (2013-04-18 19:20:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/14017012/1
7 years, 8 months ago (2013-04-19 12:50:43 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 19:01:47 UTC) #4
Message was sent while issue was closed.
Change committed as 8777

Powered by Google App Engine
This is Rietveld 408576698