Issue 14017010: [Android] Use a script on the device for creating library symlinks

Issue 14017010: [Android] Use a script on the device for creating library symlinks (Closed)

Created:
7 years, 8 months ago by cjhopman

Modified:
7 years, 8 months ago

Reviewers:
Yaron

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Use a script on the device for creating library symlinks On new versions of Android, re-installing an APK creates a new /lib/ folder for native libraries. This means we need to recreate all the symlinks in that directory (not just the ones that have changed). To make all these links quickly, it should run as a single adb command. To make that simple, we first create a simple script that, when run, creates all the symlinks for an APK. Then, after any install, we send a single adb command to run that script. This also requires that the apk_install script only triggers its dependents when it actually installs an apk. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195124

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -39 lines)			Patch
M	build/android/gyp/apk_install.py	View		2 chunks	+7 lines, -1 line	0 comments	Download
D	build/android/gyp/create_device_library_links.py	View	1 2	1 chunk	+48 lines, -29 lines	0 comments	Download
M	build/java_apk.gypi	View	1 2	3 chunks	+13 lines, -9 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Yaron

create_device_library_links is showing up as D for some reason. https://codereview.chromium.org/14017010/diff/2001/build/android/gyp/create_device_library_links.py File build/android/gyp/create_device_library_links.py (left): https://codereview.chromium.org/14017010/diff/2001/build/android/gyp/create_device_library_links.py#oldcode75 build/android/gyp/create_device_library_links.py:75: ...

7 years, 8 months ago (2013-04-18 18:06:25 UTC) #2

cjhopman

https://codereview.chromium.org/14017010/diff/2001/build/android/gyp/create_device_library_links.py File build/android/gyp/create_device_library_links.py (left): https://codereview.chromium.org/14017010/diff/2001/build/android/gyp/create_device_library_links.py#oldcode75 build/android/gyp/create_device_library_links.py:75: required_options = ['apk', 'libraries_json', 'target_dir', 'libraries_dir'] On 2013/04/18 18:06:25, ...

7 years, 8 months ago (2013-04-18 21:05:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14017010/14001

7 years, 8 months ago (2013-04-18 21:28:29 UTC) #5

commit-bot: I haz the power

Presubmit check for 14017010-14001 failed and returned exit status 1. INFO:root:Found 3 file(s). Running presubmit ...

7 years, 8 months ago (2013-04-18 21:28:31 UTC) #6

Presubmit check for 14017010-14001 failed and returned exit status 1.

INFO:root:Found 3 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1305, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1129, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1046, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 865, in CheckChangeOnCommit
  File "<string>", line 710, in _CommonChecks
  File "<string>", line 633, in _CheckForVersionControlConflicts
  File "<string>", line 623, in _CheckForVersionControlConflictsInFile
  File "/b/depot_tools/presubmit_support.py", line 549, in ChangedContents
    for line in self.GenerateScmDiff().splitlines():
  File "/b/depot_tools/presubmit_support.py", line 619, in GenerateScmDiff
    [self.LocalPath()], self._local_root, False, None)
  File "/b/depot_tools/scm.py", line 913, in GenerateDiff
    full_move, revision))
  File "/b/depot_tools/scm.py", line 837, in _DiffItemInternal
    data = SVN.Capture(command, cwd)
  File "/b/depot_tools/scm.py", line 479, in Capture
    ['svn'] + args, stderr=subprocess2.PIPE, cwd=cwd, **kwargs)
  File "/b/depot_tools/subprocess2.py", line 449, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "/b/depot_tools/subprocess2.py", line 412, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
subprocess2.CalledProcessError: Command svn diff --internal-diff
build/android/gyp/apk_install.py returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium
svn: invalid option: --internal-diff
Type 'svn help' for usage.

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14017010/14001

7 years, 8 months ago (2013-04-19 00:53:10 UTC) #7

Message was sent while issue was closed.

Change committed as 195124

Expand Messages | Collapse Messages