Issue 14017006: Tweaked Chrome hardware acceleration setting string to remove extra whitespace

Issue 14017006: Tweaked Chrome hardware acceleration setting string to remove extra whitespace (Closed)

Created:
7 years, 8 months ago by wiltzius

Modified:
7 years, 8 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

tweaked chrome strings to fix space BUG=232544 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195123

Patch Set 2 : Corrected 'line' to 'link' for standlone-link-button class #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/app/chromium_strings.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/app/google_chrome_strings.grd	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

wiltzius

Dan this is to fix the comment you made in https://chromiumcodereview.appspot.com/12494033/ that there's a bit ...

7 years, 8 months ago (2013-04-17 18:21:48 UTC) #1

Dan Beam

I don't see the class `standalone-line-button` anywhere in the codebase -- where is this?

7 years, 8 months ago (2013-04-17 19:25:28 UTC) #2

wiltzius

On 2013/04/17 19:25:28, Dan Beam wrote: > I don't see the class `standalone-line-button` anywhere in ...

7 years, 8 months ago (2013-04-17 22:14:32 UTC) #3

Dan Beam

lgtm https://codereview.chromium.org/14017006/diff/1/chrome/app/google_chrome_strings.grd File chrome/app/google_chrome_strings.grd (right): https://codereview.chromium.org/14017006/diff/1/chrome/app/google_chrome_strings.grd#newcode371 chrome/app/google_chrome_strings.grd:371: (requires Chrome <ph name="BEGIN_BUTTON"><button id="gpu-mode-reset-restart-button" type="button" class="link-button standalone-line-button"></ph>restart<ph ...

7 years, 8 months ago (2013-04-18 04:51:38 UTC) #4

wiltzius

D'oh, I see what you mean now. Sorry about that, type corrected. Thanks for the ...

7 years, 8 months ago (2013-04-18 20:21:25 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wiltzius@chromium.org/14017006/7001

7 years, 8 months ago (2013-04-18 20:21:45 UTC) #6

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30376

7 years, 8 months ago (2013-04-19 00:07:02 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wiltzius@chromium.org/14017006/7001

7 years, 8 months ago (2013-04-19 00:23:01 UTC) #8

Message was sent while issue was closed.

Change committed as 195123

Expand Messages | Collapse Messages