Move EscapeQueryStringValue to drive_api_util.

Move EscapeQueryStringValue to drive_api_util.

This method will be used a new utility method in drive_api_util. As its
preparation, this CL moves it to the drive_api_util with unittest.

BUG=232352
TEST=Ran unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194925

[hidehiko, 2013-04-18 08:21:50]

Thank you for your review in advance,
- hidehiko

[hashimoto, 2013-04-18 08:38:00]

lgtm

https://codereview.chromium.org/14013005/diff/2001/chrome/browser/google_apis...
File chrome/browser/google_apis/drive_api_util.h (right):

https://codereview.chromium.org/14013005/diff/2001/chrome/browser/google_apis...
chrome/browser/google_apis/drive_api_util.h:18: namespace drive {
Do we need this "drive" namespace inside google_apis?
How about placing the function in google_apis::util?

[hidehiko, 2013-04-18 08:42:12]

Thank you for your quick review.

https://codereview.chromium.org/14013005/diff/2001/chrome/browser/google_apis...
File chrome/browser/google_apis/drive_api_util.h (right):

https://codereview.chromium.org/14013005/diff/2001/chrome/browser/google_apis...
chrome/browser/google_apis/drive_api_util.h:18: namespace drive {
On 2013/04/18 08:38:00, hashimoto wrote:
> Do we need this "drive" namespace inside google_apis?
> How about placing the function in google_apis::util?

We're moving drive related code under google_apis into google_apis::drive.
crbug.com/180808. So, putting the function here should be fine, IMHO. WDYT?

[hashimoto, 2013-04-18 08:45:06]

https://codereview.chromium.org/14013005/diff/2001/chrome/browser/google_apis...
File chrome/browser/google_apis/drive_api_util.h (right):

https://codereview.chromium.org/14013005/diff/2001/chrome/browser/google_apis...
chrome/browser/google_apis/drive_api_util.h:18: namespace drive {
On 2013/04/18 08:42:13, hidehiko wrote:
> On 2013/04/18 08:38:00, hashimoto wrote:
> > Do we need this "drive" namespace inside google_apis?
> > How about placing the function in google_apis::util?
> 
> We're moving drive related code under google_apis into google_apis::drive.
> crbug.com/180808. So, putting the function here should be fine, IMHO. WDYT?

Oh, I've surely taken a look at that issue, but completely forgotten until now.
Thanks, lgtm.

[commit-bot: I haz the power, 2013-04-18 08:49:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/14013005/2001

[commit-bot: I haz the power, 2013-04-18 15:14:40]

Change committed as 194925