Issue 14012003: chromeos: Clean up user code of OpenNewTab in file_manager_util.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14012003: chromeos: Clean up user code of OpenNewTab in file_manager_util.cc (Closed)

Created:
7 years, 8 months ago by hashimoto

Modified:
7 years, 8 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Clean up user code of OpenNewTab in file_manager_util.cc Use the given Profile instead of the default one when possible. Fallback to file URL when something is wrong with .gdoc file. BUG=None TEST=Open a .gdoc (Google Docs) file in both Google Drive and Downloads from Files.app. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193355

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -38 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc	View		5 chunks	+30 lines, -38 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14012003/1

7 years, 8 months ago (2013-04-10 05:00:43 UTC) #3

Message was sent while issue was closed.

Change committed as 193355

Expand Messages | Collapse Messages