Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1401173009: Isolate telemetry_perf_unittests on android. (Closed)

Created:
5 years, 2 months ago by ghost stip (do not use)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate telemetry_perf_unittests on android. BUG=525873 Committed: https://crrev.com/112494ccdb12966796d1da75c44f80a39ac074a6 Cr-Commit-Position: refs/heads/master@{#354850}

Patch Set 1 #

Patch Set 2 : Get working with test binary. #

Total comments: 3

Patch Set 3 : Remove -u. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/telemetry_perf_unittests_android.isolate View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
ghost stip (do not use)
this is ready for review. ptal! https://codereview.chromium.org/1401173009/diff/20001/chrome/telemetry_perf_unittests_android.isolate File chrome/telemetry_perf_unittests_android.isolate (right): https://codereview.chromium.org/1401173009/diff/20001/chrome/telemetry_perf_unittests_android.isolate#newcode12 chrome/telemetry_perf_unittests_android.isolate:12: '../testing/scripts/run_telemetry_as_googletest.py', this will ...
5 years, 2 months ago (2015-10-19 18:15:05 UTC) #3
ghost stip (do not use)
also, I'll be asleep by the time this is fully reviewed. please CQ if it ...
5 years, 2 months ago (2015-10-19 18:15:31 UTC) #4
M-A Ruel
lgtm https://codereview.chromium.org/1401173009/diff/20001/chrome/telemetry_perf_unittests_android.isolate File chrome/telemetry_perf_unittests_android.isolate (right): https://codereview.chromium.org/1401173009/diff/20001/chrome/telemetry_perf_unittests_android.isolate#newcode11 chrome/telemetry_perf_unittests_android.isolate:11: 'python', '-u', -u should not be necessary.
5 years, 2 months ago (2015-10-19 18:23:50 UTC) #5
ghost stip (do not use)
https://chromiumcodereview.appspot.com/1401173009/diff/20001/chrome/telemetry_perf_unittests_android.isolate File chrome/telemetry_perf_unittests_android.isolate (right): https://chromiumcodereview.appspot.com/1401173009/diff/20001/chrome/telemetry_perf_unittests_android.isolate#newcode11 chrome/telemetry_perf_unittests_android.isolate:11: 'python', '-u', On 2015/10/19 18:23:50, M-A Ruel wrote: > ...
5 years, 2 months ago (2015-10-19 18:30:52 UTC) #6
Ken Russell (switch to Gerrit)
This is excellent!
5 years, 2 months ago (2015-10-19 18:45:21 UTC) #8
nednguyen(REVIEW IN OTHER ACC)
On 2015/10/19 18:45:21, Ken Russell wrote: > This is excellent! So awesome! Lgtm
5 years, 2 months ago (2015-10-19 18:59:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401173009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401173009/40001
5 years, 2 months ago (2015-10-19 19:07:53 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-19 20:21:41 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 20:22:26 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/112494ccdb12966796d1da75c44f80a39ac074a6
Cr-Commit-Position: refs/heads/master@{#354850}

Powered by Google App Engine
This is Rietveld 408576698