Issue 14011005: Use path service for chrome_exe instead of current command line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14011005: Use path service for chrome_exe instead of current command line. (Closed)

Created:
7 years, 8 months ago by calamity

Modified:
7 years, 8 months ago

Reviewers:
koz (OOO until 15th September), sky

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, jeremya+watch_chromium.org, chromium-apps-reviews_chromium.org, Aaron Boodman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Use path service for chrome_exe instead of current command line. Fix an oversight where the current command line's program was being used instead of getting the program from PathService. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194772

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/app_list/app_list_controller_win.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/views/extensions/native_app_window_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/14011005/1

7 years, 8 months ago (2013-04-18 00:23:55 UTC) #4

Message was sent while issue was closed.

Change committed as 194772

Expand Messages | Collapse Messages