content/browser/renderer_host/render_view_host_impl.cc - Issue 140073002: <webview>: navigating to WebStore should fire a loadabort instead of crashing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 140073002: <webview>: navigating to WebStore should fire a loadabort instead of crashing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index 22aa83e0eb4f7ebb34e73dfcd335a1cf4ea5d7a0..55fb58d96d291e35343af6b0dcfdae2a80ec3bcc 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1629,7 +1629,9 @@ void RenderViewHostImpl::OnToggleFullscreen(bool enter_fullscreen) {

void RenderViewHostImpl::OnOpenURL(

const ViewHostMsg_OpenURL_Params& params) {

GURL validated_url(params.url);

- GetProcess()->FilterURL(false, &validated_url);

+ // BrowserPluginGuest does filtering after firing a loadabort event.

+ if (!GetProcess()->IsGuest())

+ GetProcess()->FilterURL(false, &validated_url);

delegate_->RequestOpenURL(

this, validated_url, params.referrer, params.disposition, params.frame_id,

« chrome/test/data/extensions/platform_apps/web_view/shim/main.js ('K') | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | no next file » | no next file with comments »