Add help button to app launcher

Add help button to app launcher.

Goes to https://support.google.com/chrome/?p=cws_app_launcher.

BUG=225068
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202740

[benwells, 2013-04-10 03:46:43]

lgtm

You'll need to add a couple of empty overrides for the delegate method you're
adding into some other implementors: /ash/shell/app_list.cc and
ui/app_list/test/app_list_test_view_delegate.h

https://codereview.chromium.org/14007002/diff/1/chrome/browser/ui/app_list/ap...
File chrome/browser/ui/app_list/app_list_view_delegate.cc (right):

https://codereview.chromium.org/14007002/diff/1/chrome/browser/ui/app_list/ap...
chrome/browser/ui/app_list/app_list_view_delegate.cc:153: 
Nit: remove blank line.

https://codereview.chromium.org/14007002/diff/1/ui/app_list/app_list_view_del...
File ui/app_list/app_list_view_delegate.h (right):

https://codereview.chromium.org/14007002/diff/1/ui/app_list/app_list_view_del...
ui/app_list/app_list_view_delegate.h:78: // Open the help UI
Nit: '.' at end of comment.

[calamity, 2013-04-10 04:00:40]

+sky for OWNERS

Could you please review the following:

ui/base/strings/ui_strings.grd
ash/shell/app_list.cc

Thanks

https://codereview.chromium.org/14007002/diff/1/chrome/browser/ui/app_list/ap...
File chrome/browser/ui/app_list/app_list_view_delegate.cc (right):

https://codereview.chromium.org/14007002/diff/1/chrome/browser/ui/app_list/ap...
chrome/browser/ui/app_list/app_list_view_delegate.cc:153: 
On 2013/04/10 03:46:44, benwells wrote:
> Nit: remove blank line.

Done.

https://codereview.chromium.org/14007002/diff/1/ui/app_list/app_list_view_del...
File ui/app_list/app_list_view_delegate.h (right):

https://codereview.chromium.org/14007002/diff/1/ui/app_list/app_list_view_del...
ui/app_list/app_list_view_delegate.h:78: // Open the help UI
On 2013/04/10 03:46:44, benwells wrote:
> Nit: '.' at end of comment.

Done.

[sky, 2013-04-10 14:09:58]

LGTM

https://codereview.chromium.org/14007002/diff/6001/ui/base/strings/ui_strings...
File ui/base/strings/ui_strings.grd (right):

https://codereview.chromium.org/14007002/diff/6001/ui/base/strings/ui_strings...
ui/base/strings/ui_strings.grd:475: <message name="IDS_APP_LIST_HELP" desc="The
menu entry to show the app list help UI.">
Try to keep sorted, so move this above IDS_APP_LIST_OPEN_SETTINGS

[koz (OOO until 15th September), 2013-04-10 15:16:56]

lgtm

[commit-bot: I haz the power, 2013-05-27 07:41:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/14007002/13001

[calamity, 2013-05-27 07:47:24]

Now that the help page has come up, this can get landed.

https://chromiumcodereview.appspot.com/14007002/diff/6001/ui/base/strings/ui_...
File ui/base/strings/ui_strings.grd (right):

https://chromiumcodereview.appspot.com/14007002/diff/6001/ui/base/strings/ui_...
ui/base/strings/ui_strings.grd:475: <message name="IDS_APP_LIST_HELP" desc="The
menu entry to show the app list help UI.">
On 2013/04/10 14:09:58, sky wrote:
> Try to keep sorted, so move this above IDS_APP_LIST_OPEN_SETTINGS

Done.

[commit-bot: I haz the power, 2013-05-27 08:04:40]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-28 00:29:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/14007002/28001

[commit-bot: I haz the power, 2013-05-28 03:09:04]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-29 01:07:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/14007002/28001

[commit-bot: I haz the power, 2013-05-29 01:49:11]

Change committed as 202740