Issue 14001009: cc: Add pixel tests for PictureDrawQuad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14001009: cc: Add pixel tests for PictureDrawQuad (Closed)

Created:
7 years, 7 months ago by enne (OOO)

Modified:
7 years, 7 months ago

Reviewers:
danakj

CC:
chromium-reviews, cc-bugs_chromium.org, aelias_OOO_until_Jul13, slavi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Add pixel tests for PictureDrawQuad Add tests for simple pictures, clipped pictures, transformed pictures, scaled content rects, content subrects, and content scales. As the software renderer doesn't support picture draw quad yet, this is only turned on for the gl renderer. R=danakj@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197230

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Fixup comment #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+281 lines, -34 lines)			Patch
M	cc/output/renderer_pixeltest.cc	View	1 2	3 chunks	+249 lines, -1 line	0 comments	Download
M	cc/resources/picture_pile_impl_unittest.cc	View		10 chunks	+9 lines, -18 lines	0 comments	Download
M	cc/test/fake_content_layer_client.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cc/test/fake_content_layer_client.cc	View		1 chunk	+9 lines, -10 lines	0 comments	Download
M	cc/test/fake_picture_pile_impl.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	cc/test/fake_picture_pile_impl.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

enne (OOO)

Depends on images from: https://codereview.chromium.org/14533003

7 years, 7 months ago (2013-04-28 22:40:42 UTC) #1

danakj

LGTM https://codereview.chromium.org/14001009/diff/1/cc/output/renderer_pixeltest.cc File cc/output/renderer_pixeltest.cc (right): https://codereview.chromium.org/14001009/diff/1/cc/output/renderer_pixeltest.cc#newcode716 cc/output/renderer_pixeltest.cc:716: viewport, // intentionally bigger than clip Intentionally bigger ...

7 years, 7 months ago (2013-04-29 14:27:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/14001009/6007

7 years, 7 months ago (2013-04-29 23:04:00 UTC) #3

Message was sent while issue was closed.

Change committed as 197230

Expand Messages | Collapse Messages