Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13998027: fix launch button missing on apptool. (Closed)

Created:
7 years, 8 months ago by Gaurav
Modified:
7 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

fix launch button missing on apptool. Launch link was only getting setup for the apps which allow reload. Moving the launch button setup out. BUG=149036 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195232

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : / #

Patch Set 4 : . #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M chrome/browser/resources/apps_debugger/js/items_list.js View 1 2 1 chunk +16 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Gaurav
7 years, 8 months ago (2013-04-17 00:30:43 UTC) #1
Dan Beam
lgtm but please fix up your description (BUG=, TEST=) https://codereview.chromium.org/13998027/diff/2001/chrome/browser/resources/apps_debugger/js/items_list.js File chrome/browser/resources/apps_debugger/js/items_list.js (right): https://codereview.chromium.org/13998027/diff/2001/chrome/browser/resources/apps_debugger/js/items_list.js#newcode176 chrome/browser/resources/apps_debugger/js/items_list.js:176: ...
7 years, 8 months ago (2013-04-17 00:32:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/13998027/5001
7 years, 8 months ago (2013-04-18 17:24:57 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 17:56:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/13998027/19001
7 years, 8 months ago (2013-04-18 18:25:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=136408
7 years, 8 months ago (2013-04-18 19:50:26 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
7 years, 8 months ago (2013-04-19 01:46:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/13998027/34001
7 years, 8 months ago (2013-04-19 02:08:00 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=136686
7 years, 8 months ago (2013-04-19 05:45:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/13998027/34001
7 years, 8 months ago (2013-04-19 16:54:48 UTC) #10
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 18:04:18 UTC) #11
Message was sent while issue was closed. 
Change committed as 195232

Powered by Google App Engine
This is Rietveld 408576698