Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 13997004: Fix presubmit check compatibility with GAE SDK 1.7.6 (bis). (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Fix presubmit check compatibility with GAE SDK 1.7.6 (bis). Improve temporary storage management. Print the error message on local GAE instance failure. Useful to debug when a new version of the GAE SDK breaks something. TBR=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=194131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M testing_support/local_rietveld.py View 5 chunks +24 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
I ran the presubmit checks locally. The don't fail on the CQ because I haven't ...
7 years, 8 months ago (2013-04-15 02:31:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13997004/1
7 years, 8 months ago (2013-04-15 02:31:24 UTC) #2
commit-bot: I haz the power
7 years, 8 months ago (2013-04-15 02:34:09 UTC) #3
Message was sent while issue was closed.
Change committed as 194131

Powered by Google App Engine
This is Rietveld 408576698