Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 13996022: [Autofill] Fix test breakage under ASAN. (Closed)

Created:
7 years, 8 months ago by groby-ooo-7-16
Modified:
7 years, 8 months ago
Reviewers:
sail
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

[Autofill] Fix test breakage under ASAN. Browser tests were showing a modal dialog for OSX's Address Book. Turns of address book path for tests, re-enables test under ASAN. R=sail@chromium.org BUG=234008 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm View 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
groby-ooo-7-16
7 years, 8 months ago (2013-04-23 02:52:46 UTC) #1
sail
lgtm
7 years, 8 months ago (2013-04-23 04:15:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/13996022/1
7 years, 8 months ago (2013-04-23 17:56:17 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=32256
7 years, 8 months ago (2013-04-23 19:48:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/13996022/1
7 years, 8 months ago (2013-04-24 00:20:59 UTC) #5
commit-bot: I haz the power
Change committed as 196005
7 years, 8 months ago (2013-04-24 02:28:22 UTC) #6
groby-ooo-7-16
See comments on original bug and on https://codereview.chromium.org/14128006/ for more details
7 years, 8 months ago (2013-04-24 16:20:24 UTC) #7
groby-ooo-7-16
7 years, 8 months ago (2013-04-24 16:21:00 UTC) #8
Message was sent while issue was closed.
... more details on why this was reverted. That comment was supposed to go on
the revert :(

Powered by Google App Engine
This is Rietveld 408576698