Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: chrome/browser/extensions/extension_special_storage_policy.cc

Issue 13994010: Fix ExtensionSpecialStoragePolicy.IsInstalledApp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_special_storage_policy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_special_storage_policy.cc
diff --git a/chrome/browser/extensions/extension_special_storage_policy.cc b/chrome/browser/extensions/extension_special_storage_policy.cc
index 4017d034bbb258ade245a6c40da6b39839deebca..d142a76c900ba64a920a2f003ff6da028a4065ec 100644
--- a/chrome/browser/extensions/extension_special_storage_policy.cc
+++ b/chrome/browser/extensions/extension_special_storage_policy.cc
@@ -87,11 +87,10 @@ const ExtensionSet* ExtensionSpecialStoragePolicy::ExtensionsProtectingOrigin(
void ExtensionSpecialStoragePolicy::GrantRightsForExtension(
const extensions::Extension* extension) {
DCHECK(extension);
- if (!NeedsProtection(extension) &&
- !extension->HasAPIPermission(
- APIPermission::kUnlimitedStorage) &&
- !extension->HasAPIPermission(
- APIPermission::kFileBrowserHandler)) {
+ if (!(NeedsProtection(extension) ||
+ extension->HasAPIPermission(APIPermission::kUnlimitedStorage) ||
+ extension->HasAPIPermission(APIPermission::kFileBrowserHandler) ||
+ extension->is_app())) {
michaeln 2013/04/16 21:14:09 much more readable that way :)
return;
}
{
@@ -103,8 +102,7 @@ void ExtensionSpecialStoragePolicy::GrantRightsForExtension(
installed_apps_.Add(extension);
if (extension->HasAPIPermission(APIPermission::kUnlimitedStorage))
unlimited_extensions_.Add(extension);
- if (extension->HasAPIPermission(
- APIPermission::kFileBrowserHandler))
+ if (extension->HasAPIPermission(APIPermission::kFileBrowserHandler))
file_handler_extensions_.Add(extension);
}
NotifyChanged();
@@ -113,11 +111,10 @@ void ExtensionSpecialStoragePolicy::GrantRightsForExtension(
void ExtensionSpecialStoragePolicy::RevokeRightsForExtension(
const extensions::Extension* extension) {
DCHECK(extension);
- if (!NeedsProtection(extension) &&
- !extension->HasAPIPermission(
- APIPermission::kUnlimitedStorage) &&
- !extension->HasAPIPermission(
- APIPermission::kFileBrowserHandler)) {
+ if (!(NeedsProtection(extension) ||
+ extension->HasAPIPermission(APIPermission::kUnlimitedStorage) ||
+ extension->HasAPIPermission(APIPermission::kFileBrowserHandler) ||
+ extension->is_app())) {
return;
}
{
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_special_storage_policy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698