Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc

Issue 13994002: Try swapping tab drag tests SendKeyPress* order. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc
diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc
index 299cb16fde9f71fbcb6407cdf3cebb35d4210b9d..55083cbdb3ccd15ed424f285e6d86a13329044c4 100644
--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc
+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc
@@ -351,9 +351,10 @@ IN_PROC_BROWSER_TEST_F(TabDragControllerTest,
// TODO(msw): Fix this on "XP Tests (1)"; see http://crbug.com/227444
if (base::win::GetVersion() == base::win::VERSION_XP &&
views::Textfield::IsViewsTextfieldEnabled()) {
- LOG(INFO) << "Try SendKeyPressSync [esc]; this seems to fail...";
- ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
- browser2, ui::VKEY_ESCAPE, false, false, false, false));
+ LOG(INFO) << "Try SendKeyPressToWindowSync [esc]; maybe this works???";
+ ASSERT_TRUE(ui_test_utils::SendKeyPressToWindowSync(
+ browser2->window()->GetNativeWindow(), ui::VKEY_ESCAPE,
+ false, false, false, false));
LOG(INFO) << "Tab strip 1 drag active (expect 0): "
<< tab_strip->IsDragSessionActive();
LOG(INFO) << "Tab strip 2 drag active (expect 0): "
@@ -367,13 +368,12 @@ IN_PROC_BROWSER_TEST_F(TabDragControllerTest,
LOG(INFO) << "Tab strip 2 model string (expect '100'): "
<< IDString(browser2->tab_strip_model());
- LOG(INFO) << "Try SendKeyPressToWindowSync [esc]; maybe this works???";
- ASSERT_TRUE(ui_test_utils::SendKeyPressToWindowSync(
- browser2->window()->GetNativeWindow(), ui::VKEY_ESCAPE,
- false, false, false, false));
- LOG(INFO) << "Tab strip 1 Drag active (expect 0): "
+ LOG(INFO) << "Try SendKeyPressSync [esc]; is this needed???";
+ ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
+ browser2, ui::VKEY_ESCAPE, false, false, false, false));
+ LOG(INFO) << "Tab strip 1 drag active (expect 0): "
<< tab_strip->IsDragSessionActive();
- LOG(INFO) << "Tab strip 2 Drag active (expect 0): "
+ LOG(INFO) << "Tab strip 2 drag active (expect 0): "
<< tab_strip2->IsDragSessionActive();
LOG(INFO) << "Tab drag controller active (expect 0): "
<< TabDragController::IsActive();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698