Issue 13993005: Switch to narrowest scope for a static, per suggestion in a review on another file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13993005: Switch to narrowest scope for a static, per suggestion in a review on another file. (Closed)

Created:
7 years, 8 months ago by Jói

Modified:
7 years, 8 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch to narrowest scope for a static, per suggestion in a review on another file. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193432

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -12 lines)			Patch
M	chrome/browser/webdata/keyword_table.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/logins_table.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/token_service_table.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/web_apps_table.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/web_intents_table.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	components/webdata/autofill/autofill_table.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/13993005/1

7 years, 8 months ago (2013-04-10 16:53:31 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 8 months ago (2013-04-10 17:01:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/13993005/1

7 years, 8 months ago (2013-04-10 17:02:07 UTC) #5

Message was sent while issue was closed.

Change committed as 193432

Expand Messages | Collapse Messages