Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 13991002: views: Convert one_click_signin_bubble_view* to LabelButton. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tfarina, haitaol1, akalin, tim (not reviewing), Raghu Simha
Visibility:
Public.

Description

views: Convert one_click_signin_bubble_view* to LabelButton. BUG=155363 R=msw@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc View 4 chunks +21 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Hi Mike, please, take a look. Thanks!
7 years, 8 months ago (2013-04-10 01:20:44 UTC) #1
msw
LGTM; thanks!
7 years, 8 months ago (2013-04-10 01:22:46 UTC) #2
tfarina
TBRing Ben for this.
7 years, 8 months ago (2013-04-10 12:59:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13991002/1
7 years, 8 months ago (2013-04-10 12:59:16 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101754
7 years, 8 months ago (2013-04-10 14:46:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13991002/1
7 years, 8 months ago (2013-04-10 15:57:17 UTC) #6
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-10 16:40:19 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 17:12:06 UTC) #8
Message was sent while issue was closed.
Change committed as 193402

Powered by Google App Engine
This is Rietveld 408576698