Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 13987005: Tab audio indicator: tweak levels (Closed)

Created:
7 years, 8 months ago by sail
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Tab audio indicator: tweak levels New level values from sgabriel. BUG=3541 TBR=thakis@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193521

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/ui/tabs/tab_audio_indicator.cc View 1 chunk +8 lines, -8 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
sail
7 years, 8 months ago (2013-04-11 00:35:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/13987005/1
7 years, 8 months ago (2013-04-11 00:35:42 UTC) #2
commit-bot: I haz the power
Change committed as 193521
7 years, 8 months ago (2013-04-11 00:35:51 UTC) #3
Nico
7 years, 8 months ago (2013-04-11 04:59:39 UTC) #4
Message was sent while issue was closed.
lgtm!

https://codereview.chromium.org/13987005/diff/1/chrome/browser/ui/tabs/tab_au...
File chrome/browser/ui/tabs/tab_audio_indicator.cc (right):

https://codereview.chromium.org/13987005/diff/1/chrome/browser/ui/tabs/tab_au...
chrome/browser/ui/tabs/tab_audio_indicator.cc:28: { 1, 0, 1 },
Nit: Every line up to here contained at least one prime number (and this line
also contained prime numbers before your patch). Please add more prime numbers.

Powered by Google App Engine
This is Rietveld 408576698